LP#1526543 Truthiness check for reset_password is flawed user/dbwells/lp1526543_reset_password_disable
authorDan Wells <dbw2@calvin.edu>
Thu, 13 Feb 2014 16:56:19 +0000 (11:56 -0500)
committerDan Wells <dbw2@calvin.edu>
Tue, 15 Dec 2015 22:00:33 +0000 (17:00 -0500)
commit01e74be8cbeb125d8489317ba84acd890962c88f
treea97930a670e6e1ce110501029749032fa13f9260
parent2038e93aa68baaabe20a8b4218cfb0ed6fc5903c
LP#1526543 Truthiness check for reset_password is flawed

We expect boolean options in config.tt2 to be 'true' or 'false',
but the code was simple asking 'IF reset_password', which is true
for either value.

Instead, match on the string (as we do in other places).

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link, despite the default config
  being 'false'
- Apply patch, leaving 'reset_password' value in config.tt2 as 'false'
- RESULT: Password reset link doesn't show up

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Open-ILS/src/templates/opac/parts/login/form.tt2