LP#1562153: fix case where changing sort order to relevance can fail
authorGalen Charlton <gmc@esilibrary.com>
Fri, 25 Mar 2016 20:46:24 +0000 (16:46 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 28 Apr 2016 16:04:11 +0000 (12:04 -0400)
commit063ac67fad399b6993abca66ede7b9d498356785
tree646f40cb8eba68b6deaef8c6f9321e3ddef4fd07
parentcb5684cc8da7aa4259a0a2fc6a0ea57b50cf7222
LP#1562153: fix case where changing sort order to relevance can fail

This patch fixes a cause where sending a 'sort' CGI parameter
with the empty string as value (which specifies relevance sorting)
fails to override a previously-set sort order.

To test:

[1] Do a public catalog search starting from the advanced search form,
    e.g., keyword = "cats"
[2] Change the sort order to (say) Title A-Z from the results page.
[3] Note that the query string changes to "sort(titlesort) cats" and
    that the results are re-sorted
[4] Attempt to change the sort order to relevance.
[5] This time, the sort order does not change ... and it should have.
[6] Apply the patch and repeat steps 1-5. This time, the sort order
    should be successfully changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm