Correctly mark nested INNER joins as such
authorMike Rylander <mrylander@gmail.com>
Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 22 Aug 2013 15:39:46 +0000 (11:39 -0400)
commit0b15127aa54cd1cc3f51c757c306e7da46640be2
treed3c60e50a811a33dea9523a184ce5cad39115e6b
parent20c16ca44b4ed9c974f5a5dbc7ebb917ff5e0d10
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Conflicts [just whitespace style]:
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm