LP#904581: when calculating hold status, be more careful about fetching transits
authorGalen Charlton <gmc@esilibrary.com>
Thu, 5 Feb 2015 16:52:36 +0000 (16:52 +0000)
committerDan Scott <dscott@laurentian.ca>
Thu, 5 Mar 2015 17:43:12 +0000 (12:43 -0500)
commit0c032c5dd36ef66e52a6a3d8626a8dc3bf2a9e6a
treec0f327209a29b7bc35ee8db0b9ff0eb5e90874e2
parent4a3da4c08c65a757ac9baa8452afddc7c41abca0
LP#904581: when calculating hold status, be more careful about fetching transits

This patch fixes a problem where if a hold meets the following
criteria, an "Invalid date format: at /usr/share/perl5/Error.pm"
error can be thrown when fetching its details:

- the hold has a captured item
- the captured item has status 8 (on hold shelf)
- there is another item that is currently in transit to fill the hold
- the pickup library (or one of its ancestors) has the
  circ.hold_shelf_status_delay library setting set.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm