LP#1778783 - Circulate.pm fix log_me correct barcode var user/stompro/lp1778783_circulate_log_me_barcode
authorJosh Stompro <stompro@stompro.org>
Thu, 28 Feb 2019 15:43:49 +0000 (09:43 -0600)
committerJosh Stompro <stompro@stompro.org>
Thu, 28 Feb 2019 15:43:49 +0000 (09:43 -0600)
commit1822bd40bd7932fa12a6720a3bca4ad247ced7da
treea0981f48e484a67ebd94e27f4a6be2572af71782
parentbb6495dd8e2e7a8c8cee4577799b14b061261f21
LP#1778783 - Circulate.pm fix log_me correct barcode var

The log_me sub wasn't using the correct variable for showing the entered
barcode.  It should be $self->copy_barcode instead of $self->barcode.

Testing Notes:

Before fix:
1. Watch the logs with something like
  tail -f osrfsys.log | fgrep 'circulator: do_permit()'
2. Perform a checkout of a non-existant barcode.
3. Notice that the entered barcode is missing after 'copy='

After fix:
1. Restart the circ openils service
  osrf_control -l --service open-ils.circ --restart
2. Watch the logs.
3. Perform a checkout of a non-existant barcode.
4. Notice that the barcode is now shown after 'copy='

Signed-off-by: Josh Stompro <stompro@stompro.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm