lp1642035: Editing User Hold Preferences
The JS for hold notification values was replacing rather
than concatenating so only the furthest-right true value
would be saved. And because an ng-if directive creates
a child scope[1], the hold_notify_sms primitive could
never be true. Changed hold_notify_* to an object to
avoid this.
An ng-model directive was added to enable
opac.default_sms_notify but opac.default_sms_carrier
will still require some work to enable / replace.
[1]:https://github.com/angular/angular.js/wiki/Understanding-Scopes
Testing:
pre-patch:
Try to do anything with default sms number, fail.
Try to set more than one of phone + email notification, fail.
Try to set sms notification to anything, fail.
post-patch:
Default sms notify value is populated and can be changed.
All 8 possible combinations of hold notify options can be set.
Still can't set opac.default_sms_carrier value, needs additional work.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>