LP 115706: Avoid Internal Server Errors with Hold Count Retrieval
authorJason Stephenson <jason@sigio.com>
Tue, 7 Aug 2018 14:02:10 +0000 (10:02 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 31 May 2019 14:44:04 +0000 (10:44 -0400)
commit2431aacd734227b61487224986a0d52cbfd800d0
treea76da09ec75b3a24f19adc04667ab410baca9bd6
parentbee1f478878b7d06732da716932e52d2601a7ab3
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval

It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason.  When this happens,
the user sees an Internal Server Error.  The underlying cause is the
following Perl error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.

This commit rearranges the code around that line to avoid this
particular undefined value reference error.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm