lp1859502 fix A/T ApplyPatronPenalty reactor
authorJason Etheridge <jason@EquinoxInitiative.org>
Mon, 13 Jan 2020 17:38:53 +0000 (12:38 -0500)
committerJason Etheridge <jason@EquinoxInitiative.org>
Tue, 4 Feb 2020 02:42:45 +0000 (21:42 -0500)
commit25bdfb612f590bd190b59acf739e7db0a73ad00c
treec7a265ac2baa1e0857274260101a061a2b6f6c0e
parent851572686b9d3c827bca282449d66299cc929e2e
lp1859502 fix A/T ApplyPatronPenalty reactor

To test this, you could create the following A/T definition:

    Owning Library: CONS
    Name: test lp1859502
    Hook: penalty.PATRON_EXCEEDS_FINES
    Enabled: True
    Processing Delay: 00:00:00
    Processing Group Context Field: usr
    Reactor: ApplyPatronPenalty
    Validator: NOOP_TRUE
    Max Event Validity Delay: 1 day
    Template: test message

with environment:

    Field Path: usr
    Label: user

    Field Path: usr.home_ou
    Label: context_org

with event params:

    Parameter Name: standing_penalty
    Parameter Value: ALERT_NOTE

Then bill a test patron for $100 and run something like:

/openils/bin/action_trigger_runner.pl --osrf-config /openils/conf/opensrf_core.xml --run-pending

Without the patch, you'll get something like this in osrfsys.log:

ApplyPatronPenalty: missing parameters

And no ALERT_NOTE penalty.  With the patch you should see a "test message" alert note
when reloading the patron.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/ApplyPatronPenalty.pm