LP#904581: when calculating hold status, be more careful about fetching transits
authorGalen Charlton <gmc@esilibrary.com>
Thu, 5 Feb 2015 16:52:36 +0000 (16:52 +0000)
committerBen Shum <bshum@biblio.org>
Mon, 23 Feb 2015 22:05:55 +0000 (17:05 -0500)
commit2c0d82dac53ef965e0588c678bfe7e788f1b7cd6
treeffe3b8563bb4dae70ea4de762059e90b83558413
parentf0ad0694c3e2981fb03cd417beb66215c302a7bc
LP#904581: when calculating hold status, be more careful about fetching transits

This patch fixes a problem where if a hold meets the following
criteria, an "Invalid date format: at /usr/share/perl5/Error.pm"
error can be thrown when fetching its details:

- the hold has a captured item
- the captured item has status 8 (on hold shelf)
- there is another item that is currently in transit to fill the hold
- the pickup library (or one of its ancestors) has the
  circ.hold_shelf_status_delay library setting set.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm