LP1735566: Ask before deleting items in non-ideal statuses in AngularJS
authorJane Sandberg <sandbej@linnbenton.edu>
Thu, 17 Oct 2019 18:11:34 +0000 (11:11 -0700)
committerChris Sharp <csharp@georgialibraries.org>
Wed, 19 Aug 2020 15:07:36 +0000 (11:07 -0400)
commit2d581bd51d1188e52c8963e95dcd0978e9b3aeb9
tree69be3643f04de0771dfc96c23fbc07a15e8bd217
parentdfd4b03304b3dcd0fc1e5b2dada16da386158f7d
LP1735566: Ask before deleting items in non-ideal statuses in AngularJS

To test:

1) Apply this commit.
2) Log in as a user with COPY_DELETE_WARNING.override permission.
3) Go to item status and scan an item in a non-ideal status (like #1:
checked out)
4) Delete the item.  Note that you are alerted of the item's non-ideal
status, and you can confirm that you actually want to delete it.
5) Repeat steps 3-4 with an item in an ideal status (like #0:
Available). Note that no such alert appears.
6) Open the holdings view and repeat steps 4-5.
7) Log in as a user without the COPY_DELETE_WARNING.override
permission. Note that you are still informed about the non-ideal status,
but you aren't able to continue with the deletion without an admin
using their credentials.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/templates/staff/cat/catalog/index.tt2
Open-ILS/src/templates/staff/circ/share/circ_strings.tt2
Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
Open-ILS/web/js/ui/default/staff/circ/services/item.js