fix issue with nested .xhtml includes user/gmcharlt/nested_reports_includes
authorGalen Charlton <gmc@equinoxinitiative.org>
Mon, 23 Sep 2019 21:15:16 +0000 (17:15 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Mon, 23 Sep 2019 21:15:16 +0000 (17:15 -0400)
commit2fbac228cf82853d203e41e0a0c2d8db56ca580f
treedd987c54b822c0b05f8490859b81b15086e1c4e0
parentefde2a454dc26bd9b5201aa2ab1af1f259250067
fix issue with nested .xhtml includes

This WIP patch fixes an issue where oils_rpt.xhtml fails to
get completely loaded due to an XML parsing error thrown
by mod_xmlent.

The problem appears to be that oils_rpt_param_editor.xhtml
gets included via mod_include and processed by mod_xmlent...
in the context of an overall chain of mod_include and mod_xmlent
that is filtering the overall request for oils_rpt.xhtml.

However, if the same Apache backend processes both the main
request and a sub-request to fetch the included file, the
fact that the Expat parser is shared by all invocations of
mod_xmlent for a given Apache backend is somehow leading
to chunks of oils_rpt.xhtml and the files it's bringing
via mod_include getting processed out of order.

Renaming oils_rpt_param_editor.xhtml to /oils_rpt_param_editor.txt
means that the sub-request to include that file does _not_
pass it through mod_xmlent, avoiding this problem.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/web/reports/oils_rpt_editor.xhtml
Open-ILS/web/reports/oils_rpt_param_editor.txt [new file with mode: 0644]
Open-ILS/web/reports/oils_rpt_param_editor.xhtml [deleted file]