Fix a problem with open-ils.circ.holds.retrieve_all_from_title
authorLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Fri, 20 May 2011 14:17:05 +0000 (10:17 -0400)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Fri, 20 May 2011 14:21:28 +0000 (10:21 -0400)
commit31b02f3b28493c6a68131511627a2ca929e16e4f
tree550c6453669f7ae366743a784ea799a4253d5600
parent7eed24efc3ac0ffc7269002c76f5b6509903498f
Fix a problem with open-ils.circ.holds.retrieve_all_from_title

Anoop Atre spotted this bug that's triggered by selecting "View Holds"
from "Actions for Selected Record" in the catalog seen through the staff
client.

Said method would error out like this:

[2011-05-20 10:04:03] open-ils.circ [ERR
:31866:CStoreEditor.pm:109:13058333633194115] editor[0|1] request error
open-ils.cstore.direct.serial.issuance.id_list.atomic :
{"subscription":[]} : Exception:
OpenSRF::DomainObject::oilsMethodException 2011-05-20T10:04:03
OpenILS::Utils::CStoreEditor
/openils/lib/perl5/OpenILS/Utils/CStoreEditor.pm:412 <500>  Severe query
error -- see error log for more details

because when trying to gather issuance-type holds, it didn't properly test
whether there actually were any subscriptions and issuances related to
the bib record in question.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm