LP#902255: Correct "ILS Event at check in" logic
authorMike Rylander <mrylander@gmail.com>
Thu, 11 Jun 2015 12:49:21 +0000 (08:49 -0400)
committerJason Stephenson <jstephenson@mvlc.org>
Mon, 15 Jun 2015 19:16:33 +0000 (15:16 -0400)
commit3f2da158a2070c1cb722b4bb18d94794cf5116b6
treef51ada3df7cf9da4a12c44daa8a91642384f9355
parent8edddd734d7843cbb920c2376b094a9abfd4ee99
LP#902255: Correct "ILS Event at check in" logic

In a classic case of "fix a bug to reveal another" it turn out that
there was a small logic bug hiding in the check in hold-capture code.
The result of this bug was that the wrong ILS Event object was being
returned when we ran into the double-scan hold-capture situation by
overwriting the correct one immediately after we construct it, which
in turn prevented the previous commit from working as designed.

We now return the correct ILS Event immediately so that we can
properly detect the situation.  Two birds with one branch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm