LP#1373578: fix translatability of hold placement errors user/gmcharlt/lp1373578_dont_maketext_empty_string
authorGalen Charlton <gmc@esilibrary.com>
Mon, 23 May 2016 16:29:04 +0000 (12:29 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 23 May 2016 16:29:04 +0000 (12:29 -0400)
commit4e729cf35c4966648a7fb37cf5f19c8951d02e60
tree2f3deddaba94fb52610d0bef64d6a7d3d0de5bc8
parent2f024d424fefe801aafaf9f9b2debab0c6b74483
LP#1373578: fix translatability of hold placement errors

This patch fixes a circumstance where ->maketext() could be
passed an empty string, causing it to emit the PO file header text
rather than a desired string.

To test
-------
[1] Configure Evergreen to use a TPAC localization (e.g.,
    the Czech translation).
[2] Enable the "Has Local Copy Alert" library setting.
[3] In the OPAC, change locale and attempt to place a
    hold that would trigger the alert saying that there's
    already a local copy available.
[4] Note that the alert reads as "Project-Id-Version: evergreen
    Report-Msgid-Bugs-To: ..."
[5] Apply the patch.
[6] Try step 3; this time the alert will be translated correctly,
    e.g., "Ve vaší domovské knihovně je již dostupný exemplář."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Open-ILS/src/templates/opac/parts/place_hold_result.tt2