LP1948594: Fix pgtap live test
authorJason Stephenson <jason@sigio.com>
Sun, 24 Oct 2021 18:38:52 +0000 (14:38 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Fri, 5 Nov 2021 16:13:01 +0000 (12:13 -0400)
commit5009e5924ede6cb0762619413e72fbcea97ebb38
treeb54cc82f649b5bf4c459ade3e36df52dbd23687d
parent8520d171921a41a8a5b5d359ed5af492eb4d85d9
LP1948594: Fix pgtap live test

Fix the lp1145213_test_func_asset.merge_record_assets.pg pgtap live
test by removing the COMMIT and adding a ROLLBACK at the end.  This
permits the test to run multiple times without requiring a database
reload.

To verify the bug:

1. Install the pgtap package appropriate for your PostgreSQL database
version.

2. Load a fresh database with eg_db_config using the --load-all-sample
option.

3. Create the pgtap extension in the evergreen database.

4. Run the Open-ILS/src/sql/Pg/live_t/ tests with pg_prove.

5. Repeat step 4, and if this patch has not been applied, then the
lp1145213_test_func_asset.merge_record_assets.pg tests will fail on
the second run.

To test the fix, repeat steps 2 - 5, above, after pulling this commit.
Step 5 should succeed.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/sql/Pg/live_t/lp1145213_test_func_asset.merge_record_assets.pg