LP1599634: follow-ups
authorblake <blake@mobiusconsortium.org>
Thu, 10 Nov 2016 23:06:39 +0000 (17:06 -0600)
committerGalen Charlton <gmc@equinoxinitiative.org>
Tue, 4 Apr 2017 14:29:18 +0000 (10:29 -0400)
commit5f26da6220906be586d43158449d76c19559323f
treed30d084d79b6c8ec4c8f91202d1f4afd01f62bf5
parent4e64cbbc4cdda08a60d3e9c45a90f2e9ca0309f5
LP1599634: follow-ups

Squashed patch containing follows-ups written by Chris Sharp
and Galen Charlton:

*  When running the upgrade script, the DROP VIEW statement resulted in an
error since the view did not already exist.  You could add IF EXISTS, but
CREATE OR REPLACE VIEW is sufficient.

* Changes the ID column to just pass through
the ID from the source tables, promoted to BIGINT in
some cases.  This has the effect of:

- removing a redundancy, as circ_type already specifies the source table
- making it easier to join this view against the circulation tables when
  writing SQL queries

* Renames the schema upgrade script to better
match conventions.

* Move release notes entry so that it will get picked up

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/examples/fm_IDL.xml
Open-ILS/src/sql/Pg/090.schema.action.sql
Open-ILS/src/sql/Pg/upgrade/XXXX.LP1599634_Circulation_report_source_to_include_in-house_and_non_cat_circ [deleted file]
Open-ILS/src/sql/Pg/upgrade/XXXX.schema.all_circulation_combined_types_view.sql [new file with mode: 0644]
docs/RELEASE_NOTES_NEXT/Reports/lp1599634_Circulation_report_source_to_include_in-house_and_non_cat_circ.adoc [new file with mode: 0644]
docs/lp1599634_Circulation_report_source_to_include_in-house_and_non_cat_circ.adoc [deleted file]