Make users_of_interest test for defined actor.usr.card values
authorMichael Peters <mpeters@emeralddata.net>
Thu, 20 Nov 2014 22:41:44 +0000 (17:41 -0500)
committerChris Sharp <csharp@georgialibraries.org>
Wed, 25 Nov 2020 16:43:06 +0000 (11:43 -0500)
commit6c78df1ac4e25cfe85a074106d68ad6cfc9084ab
tree0d95fc0c089babbcb09856397701da7c810ce251
parentc4014ab7119ac4ef6d6c66962546d18fa7a99b67
Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm