Correctly mark nested INNER joins as such user/jboyer/clark-nested-inner-join-signoff
authorMike Rylander <mrylander@gmail.com>
Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)
committerJason Boyer <jboyer1@library.in.gov>
Wed, 21 Aug 2013 12:38:35 +0000 (08:38 -0400)
commit6d94ce5923c1a09c5e0839b863af828d3c081c87
treee71c083f0e92060bfa61e5681050bf9987c4df19
parent856e992c21ce0812d36248a502b2ebb0601ee215
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm