LP#1379824 Make PermaCrud.js disconnect() actually disconnect
authorDan Wells <dbw2@calvin.edu>
Thu, 9 Oct 2014 21:32:42 +0000 (17:32 -0400)
committerBen Shum <bshum@biblio.org>
Fri, 10 Oct 2014 19:05:52 +0000 (15:05 -0400)
commit6e9fd31cdd3cd9a8f38fda9c8d2bdd082e1c34d4
treea28d2ad432de999f68194ddce1da6981211ffd77
parent0fa5d67e9ecdd6e8261b100c70c2cab5f6289d55
LP#1379824 Make PermaCrud.js disconnect() actually disconnect

The disconnect() method in PermaCrud.js was meant to wrap the
underlying session disconnect, but it never actually disconnected
the session.  This could lead to problems in long-living PermaCrud
objects, as they may think they are still connected when they are not
(the session remote_id is never cleared).

Also, remove a couple (now redundant) manual session.disconnect() calls.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/web/js/dojo/openils/PermaCrud.js