LP#1721807: fix webstaff report templates that have might_have and has_many joins
authorGalen Charlton <gmc@equinoxinitiative.org>
Tue, 6 Mar 2018 23:00:23 +0000 (18:00 -0500)
committerChris Sharp <csharp@georgialibraries.org>
Fri, 21 Sep 2018 17:03:52 +0000 (13:03 -0400)
commit7406ebc134118dbf2b6c93be94794f3ceec51fcd
treed49b31147deb92ddc90cc7416d1522026efb1fca
parentaee918b0f274b0aaf91b76c9e0ba6157372d2402
LP#1721807: fix webstaff report templates that have might_have and has_many joins

This patch fixes a bug where using a virtual field in the web staff
report template editor to join another table would result in a syntax
error in the generated SQL.

To test
-------
[1] Apply the patch and verify that the regression test in the previous
    commit passes.
[2] Create new report template in the web staff client that include
    virtual fields and joins and verify that they work. One example
    would be a report that uses ILS User as the base source and joins
    in the patron notes virtual field.
[3] If available, clone a report template originally created in the web
    staff client that had previously failed, then save it. The new
    report should work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/web/js/ui/default/staff/reporter/template/app.js