LP#1749795 Close circ on adjustment when rebilled user/dbwells/lp1749795_close_xact_adjust_fix
authorDan Wells <dbw2@calvin.edu>
Mon, 30 Apr 2018 15:05:11 +0000 (11:05 -0400)
committerDan Wells <dbw2@calvin.edu>
Mon, 30 Apr 2018 16:35:44 +0000 (12:35 -0400)
commit75ef797da3ee587a8fc7f8cdf78e5b0b10fda9f4
tree77bac93917d2b4f46fc4eaff01832c5974958fc9
parent415509cf6e68163efbb09658df8edca6df6d2a2d
LP#1749795 Close circ on adjustment when rebilled

When doing a re-bill, we were aborting too early when it rebilled to
exactly zero.  Move the 'zero' check to the top of the loop, and
thereby make sure we check if the xact can be closed if we do any
adjustment, up or down.

To test:
- Run new billing test from previous commit, see it fail
- Apply patch
- Run tests again; all should pass

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm