LP#1568195: fix retrieving big OUS batches
authorGalen Charlton <gmc@esilibrary.com>
Sat, 9 Apr 2016 01:46:35 +0000 (21:46 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 28 Apr 2016 15:55:00 +0000 (11:55 -0400)
commit904ad79f0a7d114454d08b2822f955e10bc7bf73
tree8606796e035c031d86b7bfa95e5db29748a0bf31
parentc86b93b9c3a2e49934072b2bab8388c81dfe8cf7
LP#1568195: fix retrieving big OUS batches

This patch fixes a regression introduced in LP#1501471
where the Library Settings Editor could fail to retrieve
the values of org unit settings if more than 99 were
requested at a time.

To test
-------
[1] Open the XUL library settings editor and ensure that
    no search filters are in effect. Note that values
    are not displayed for any of the OU settings, and that
    the Pg log contains error messages like this:

    "ERROR: cannot pass more than 100 arguments to a function"

[2] Apply the patch.
[3] Repeat step one, and verify that values are now retrieved
    for all of the OU settings that have values set.
[4] Verify that the pgTAP tests in live_t/aous_batch.pg pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
Open-ILS/src/sql/Pg/020.schema.functions.sql
Open-ILS/src/sql/Pg/live_t/aous_batch.pg
Open-ILS/src/sql/Pg/upgrade/XXXX.schema.make_ous_batch_retrieve_func_nonvariadic.sql [new file with mode: 0644]