LP#1743262 CC external payment requires app. code
authorBill Erickson <berickxx@gmail.com>
Mon, 5 Feb 2018 21:24:38 +0000 (16:24 -0500)
committerGalen Charlton <gmc@equinoxinitiative.org>
Tue, 6 Feb 2018 21:03:14 +0000 (16:03 -0500)
commit98181a36b0748e0aac52d22d5a93c6b8af1bd453
tree54dc0370569ce609f12db9105561ba6662e1aa63
parentba3c0e4c8eb2ef4003262056b5b706218c7de261
LP#1743262 CC external payment requires app. code

1. Indicate in the CC form that the approval_code field is required,
   styled consistently with the patron edit app.

2. Prevent the form dialog from closing via Submit when no approval code
   is set.

3. Handle payment failures better by preventing the post-API code from
   running (i.e. receipt printing) when the API fails.

To test
-------
[1] In the web staff client, attempt to record an externally-supplied
    credit card payment without specifying an approval code. Note that
    an alert message is presented.
[2] Apply the patch and repeat step 1. This time, the approval code is
    displayed as a required field and the dialog cannot be submitted
    until one is specified.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/templates/staff/circ/patron/t_cc_payment_dialog.tt2
Open-ILS/src/templates/staff/css/circ.css.tt2
Open-ILS/web/js/ui/default/staff/circ/patron/bills.js