Correctly mark nested INNER joins as such
authorMike Rylander <mrylander@gmail.com>
Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 22 Aug 2013 15:40:32 +0000 (11:40 -0400)
commit99cc0c0fe9550f5d0731f042df8341de46ed1198
treeeec13bc1bc94b0339ed79f860a2236d5022b6f0e
parent3e7f6f8bdf1c11b557df000c22d6809cc8e62698
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Conflicts [just whitespace style]:
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm