LP 115706: Avoid Internal Server Errors with Hold Count Retrieval
authorJason Stephenson <jason@sigio.com>
Tue, 7 Aug 2018 14:02:10 +0000 (10:02 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 31 May 2019 14:43:59 +0000 (10:43 -0400)
commita41293876013d141adbf0fc7455ef812ca441dda
treeaf082550c990ad221541fa1dc7106d7051774afb
parentfca14f30f33943bbbff79c10f945eca4a82b4a21
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval

It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason.  When this happens,
the user sees an Internal Server Error.  The underlying cause is the
following Perl error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.

This commit rearranges the code around that line to avoid this
particular undefined value reference error.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm