LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon user/dyrcona/lp1496977_assetcommon_dup_code
authorJason Stephenson <jstephenson@mvlc.org>
Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)
committerJason Stephenson <jstephenson@mvlc.org>
Thu, 17 Sep 2015 19:25:05 +0000 (15:25 -0400)
commita597e691a54dfba450cce41178a227ef443793ef
tree78a409c71ab7d8e6fa31818d65af99a0a59a74d4
parent729a4b2914ce09a52bea457f7b0e7101fb482229
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon

It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon.  This duplication can lead to data loss for the function
update_fleshed_copies.  It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:

"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.

After this patch, the warning disappears.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm