LP#1468422 Report inactive card on password OK
authorBill Erickson <berickxx@gmail.com>
Mon, 11 Jan 2016 16:02:23 +0000 (11:02 -0500)
committerDan Wells <dbw2@calvin.edu>
Fri, 26 Feb 2016 14:18:21 +0000 (09:18 -0500)
commita82cede6c4be7973927071bbaaf7eaf041fe6efc
tree83ae83ebbeeabbb2d6ebf2bb398dcaddbbc6c5ef
parentd98aff96c97d53bebed1e540b6a73d4e5742e50b
LP#1468422 Report inactive card on password OK

Prevent leaking information from authentication by only reporting that a
card is inactive if the caller provided the correct credentials.  This
is consistent with how the code handles inactive patrons.

To avoid a lot of code duplication and to reduce the potential for
leaking memory (C code, amiright?), this commit includes a number of
changes to avoid exiting the API function early and saving the memory
cleanup routines until the end of the API call.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/src/c-apps/oils_auth.c