return, not next, from eval BLOCK
authorDan Scott <dscott@laurentian.ca>
Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)
committerBill Erickson <berick@esilibrary.com>
Fri, 21 Jun 2013 13:09:21 +0000 (09:09 -0400)
commita8971b7ff2fe313ca22f5439e422c061684cb187
tree6c9674b56c864fe8b2cf236fca582bbcac334a1d
parent72d2ddd5076e72bfc8c3dbf64e3d892e3aa78a38
return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm