LP#1857156: handle HHH:MM:SS durations in loans
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 20 Dec 2019 17:55:16 +0000 (12:55 -0500)
committerChris Sharp <csharp@georgialibraries.org>
Wed, 19 Aug 2020 15:07:36 +0000 (11:07 -0400)
commitab711ba3085c02a144e800c11c9e10b4d130d39c
tree4f515c8c95a1dd26aae3ba69c8d0f024aed7f7ce
parent03c11f16f88f73d250c5f19633cacaa16f1d34a5
LP#1857156: handle HHH:MM:SS durations in loans

This patch fixes a problem where loan durations of the form
HHH:MM:SS, where the hours component is longer than 2 digits, could
cause checkouts to fail. This sort of duration has been observed
in cases where a library wanted a long-term reserves loan that
doesn't have the due time bumped up to midnight.

To test
-------
[1] Set up a circulation policy that has a loan duration of 167:59:59.
[2] Attempt a checkout that uses that policy. Note that the checkout
    will fail.
[3] Apply the patch and repeat step 2. This time, the checkout should
    succeed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Open-ILS/src/perlmods/lib/OpenILS/Utils/DateTime.pm
Open-ILS/src/perlmods/t/14-OpenILS-Utils.t