LP#1746815: Fix sticky hold url param
authorCesar Velez <cesar.velez@equinoxinitiative.org>
Mon, 5 Feb 2018 22:45:22 +0000 (17:45 -0500)
committerGalen Charlton <gmc@equinoxinitiative.org>
Fri, 25 May 2018 17:43:25 +0000 (13:43 -0400)
commitad604edf81b593983cbc51343b8f858e26a8dd9c
tree9ee225f9c96ab19de4d82091953a5a36a33ddc05
parent76fe8fb114a4c1b0e27dc99bd466e58b40772681
LP#1746815: Fix sticky hold url param

Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.

To test
-------
[1] Log in to the public catalog as a patron that has at least
    two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
    'id' URL parameter persists as you navigate through the public
    catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
    see all of the holds.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
Open-ILS/src/templates/opac/myopac/holds.tt2
Open-ILS/src/templates/opac/parts/myopac/base.tt2
Open-ILS/src/templates/opac/parts/topnav.tt2