Stop saving patron barcode in cookies
authorThomas Berezansky <tsbere@mvlc.org>
Fri, 30 Mar 2012 19:58:32 +0000 (15:58 -0400)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Tue, 8 May 2012 17:32:35 +0000 (13:32 -0400)
commitb52dac83fd59f45e94dcf05c5b9c633c4ad05135
treececaf145edd33477123c17a67f6235abbc10322a
parentb2916b9fef744d8b896c77511e949612d26dff36
Stop saving patron barcode in cookies

This causes bad interactions between patron windows and normal catalog
windows. Examples:

Load a patron, load place hold catalog in patron window. Future loads of
non-patron catalogs will default to this patron.

Load Patron A from written note, and open Place Hold catalog. Start
searching for the item Patron A wants.
Get interupted by Patron B calling. Load Patron B, and open Place Hold
catalog. Search, place a hold for Patron B.
Return to Patron A, find item, go to place hold. Find Patron B's barcode
populated.

Instead, teach the staff javascript, that already knows how to load hold
preferences, how to grab the barcode from xulG. This barcode should be
specific to the patron window the catalog is embedded in, and won't 'leak'
to other catalog interfaces.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
Open-ILS/src/templates/opac/parts/place_hold.tt2
Open-ILS/web/js/ui/default/opac/staff.js
Open-ILS/xul/staff_client/server/patron/holds.js