LP#1749795 Close circ on adjustment when rebilled
authorDan Wells <dbw2@calvin.edu>
Mon, 30 Apr 2018 15:05:11 +0000 (11:05 -0400)
committerChris Sharp <csharp@georgialibraries.org>
Wed, 11 Jul 2018 21:09:26 +0000 (17:09 -0400)
commitbb594ad94f9292399595fa698e703d97e0a0197d
treed387faddbac19186f7badccf08f6f398127e2d42
parent5fed92e899c457f5cdb0f0a2241c9d9d6b688cb3
LP#1749795 Close circ on adjustment when rebilled

When doing a re-bill, we were aborting too early when it rebilled to
exactly zero.  Move the 'zero' check to the top of the loop, and
thereby make sure we check if the xact can be closed if we do any
adjustment, up or down.

To test:
- Run new billing test from previous commit, see it fail
- Apply patch
- Run tests again; all should pass

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm