LP 1198465: Fix and improve void/adjustment code
authorDan Wells <dbw2@calvin.edu>
Wed, 26 Feb 2014 22:44:45 +0000 (17:44 -0500)
committerKathy Lussier <klussier@masslnc.org>
Fri, 24 Jul 2015 00:17:52 +0000 (20:17 -0400)
commitbc063644d88afc4ce3abf23d3f5bcbcb30aa5160
tree0b9133de1cc6859ac02b60a8d85c69f1e3af4d48
parent6093dbcc6f4e78a8f4b737c5a5e6a3c51738e85b
LP 1198465: Fix and improve void/adjustment code

This commit does three things:

- Replace ou_ancestor_setting() with ou_ancestor_setting_value() calls
  This also fixed a bug where we were expecting just the setting, not
  a HASH

- Reword interval checking
  This fix is two part.  First, we simplify the check to not require
  the whole payment map.  Second, we use this newfound simplicity to
  push this check up into the gatekeeper functions, further clarifying
  the code paths.

- make $note into $for_note for void_or_zero_bills_of_type()
  Because the function can both void and adjust, we can't supply a
  complete note, so let's just supply text of what the void/adjustment
  is for.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm