TPAC: Avoid 500 errs on record page due to ipv6 ignorance
authorDan Scott <dscott@laurentian.ca>
Thu, 11 Oct 2012 02:06:32 +0000 (22:06 -0400)
committerBill Erickson <berick@esilibrary.com>
Thu, 11 Oct 2012 13:55:34 +0000 (09:55 -0400)
commitc650360b7adb7f1f25ac176b45d3598591fdf05c
tree1ab56545a3b82faa48ec9ae38b28f2cb122514d6
parent055c5afc7c387faeba0ddfb459de484f17cc5858
TPAC: Avoid 500 errs on record page due to ipv6 ignorance

Net::HTTP does not handle ipv6 addresses properly, and is subject to
failing to return a request object if handed one (some systems seem to
prefer ipv6). This commit checks the value of the request object before
invoking any methods on it, and also short-circuits the AC lookup loop
if the host could not be resolved to avoid flooding the logs with
multiple "Unable to connect..." warnings.

If Net::HTTP grows ipv6 support, this commit can still stay in place and
the lookups will just start magically working.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm