LP#1449283: fix auth when running under Apache 2.4
authorGalen Charlton <gmc@esilibrary.com>
Thu, 30 Apr 2015 18:07:14 +0000 (11:07 -0700)
committerBill Erickson <berickxx@gmail.com>
Fri, 1 May 2015 20:17:12 +0000 (16:17 -0400)
commitc7502c4038dce4eab673b6e7f4fca23bd1c17f9a
tree4c4a8e620f4034da81eca4f771470b61ecb6c1ac
parenta826c711450da39db1ec414ad3a8b9cdee733f28
LP#1449283: fix auth when running under Apache 2.4

When running under Apache 2.4 using the stock configuration
derived from apache_24/eg_vhost.conf.in, protected
URLs such as https://eghost/reporter/ that are meant to
require valid EG staff credentials were not in fact
requiring authentication.

This patch does the following to fix this:

[1] Removes several uses of "Require all granted" that
    was causing authentication to be ignored.
[2] Changes OpenILS::WWW::Proxy::Authen so that it always
    sets the username in the Apache request object if
    authentication was successful; it appears that starting
    with Apache 2.4, authentication handlers must ensure
    that a user name is set for a "Require valid-user"
    directive to work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/examples/apache_24/eg_vhost.conf.in
Open-ILS/src/perlmods/lib/OpenILS/WWW/Proxy/Authen.pm