return, not next, from eval BLOCK
authorDan Scott <dscott@laurentian.ca>
Fri, 21 Jun 2013 03:39:21 +0000 (23:39 -0400)
committerDan Scott <dscott@laurentian.ca>
Fri, 21 Jun 2013 04:02:59 +0000 (00:02 -0400)
commitcb2144341639b8648ba116c47130697f9fa0db2e
tree88f064c503758d7eddc439f026c8fcfd3f7f3ff4
parent1bb05b3732643ddbbc0a4ca4ef1553ef44749fc0
return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm