Fix: Current Bills thinks it is Bill History
authorJeff Godin <jgodin@tadl.org>
Wed, 21 Sep 2011 20:41:19 +0000 (16:41 -0400)
committerJason Etheridge <jason@esilibrary.com>
Fri, 23 Sep 2011 20:26:15 +0000 (16:26 -0400)
commitcecf19e320d79ecb6c752eedf5533958730b5c49
tree525d260e8893b5f401991c334d33a0307121a746
parente0f5cd46458c51a0b2446046c9042c4429d83023
Fix: Current Bills thinks it is Bill History

This fixes LP 855894: Bills interface calls itself Bill History,
uses bills_historical receipt template

https://bugs.launchpad.net/evergreen/+bug/855894

At some point in development, the Current Bills and the Bill History
interface were in a unified file, with an xul_param of "current" used
to switch between the two.

Nothing currently sets the xul_param "current", so the Current Bills
interface (bill2.xul and bill2.js) was improperly:

* not hiding the xact_finish column
* using a caption label of "Bill History"
* using the bills_historical receipt template

The Bill History interface was okay -- "not current" was the default.

This commit removes the tests for xul_param('current') and uses the
appropriate code for each interface.

// this code in both bill2.js and bill_history.js:
var template = 'bills_historical';
if (xul_param('current')) template = 'bills_current';

// becomes:
var template = 'bills_current';    // in bill2.js
var template = 'bills_historical'; // in bill_history.js

Also: added missing staff.patron.bill_interface.caption.label entity

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Open-ILS/web/opac/locale/en-US/lang.dtd
Open-ILS/xul/staff_client/server/patron/bill2.js
Open-ILS/xul/staff_client/server/patron/bill_history.js