LP 1855781 fixup collab/phasefx/lp1855781-circulation-policy-configuration
authorJason Etheridge <jason@EquinoxOLI.org>
Wed, 14 Dec 2022 21:45:10 +0000 (16:45 -0500)
committerJason Etheridge <jason@EquinoxOLI.org>
Wed, 19 Apr 2023 13:52:14 +0000 (09:52 -0400)
commitd33604bb25c89d8de8062a12cda91915da28c904
treef2ff2be6d34f39f44578daf6d97d92bdf5075735
parent5514e3b8636fd2f02b436a6f5d4b52a14df1c78a
LP 1855781 fixup

* put out some fires after rebasing and smoketesting
* persistKey to enable Save Grid Settings
* disable Edit Selected action unless exactly one row is selected
* allow for the explicit setting of null for certain eligible fields in fmEditor
* support appending custom templates to fields in fmEditor
* simplify/robustify the insertion of dividers in fmEditor here with the new appendTemplate fmOption
* i18nize this helpText
* style this header the same way as the fmEditor
* required property seems to work for eg-org-select
  well, just the styling.  Could maybe replace eg-org-select with eg-org-family-select which has some form smarts
* release notes

Additional tweaks since the last pullrequest:

* replacing checkboxes with eg-bool-select in fm-editor
* required and validation for eg-bool-select
* Change Copy Location to Shelving Location in the IDL

    If we wanted to catch every instance of Copy Location, we
    could do something like

    ack -li 'copy location' > /tmp/list.txt
    # vim /tmp/list.txt # some care needed with pruning the list. Worthy of its own ticket and commit, IMO
    for x in `cat /tmp/list.txt` ; do sed -i 's/copy location/Shelving Location/gi' $x ; done

* fix a typo and relabel the new policy button
* relabel some more fields in the IDL

    "Copy Circ Lib" and "Copy Owning Lib" become "Item Circ Library" and "Item Owning Library", respectively.

* Org Unit becomes Checkout Library for the circ matrix.  Checkout is more prevalent in the code than Check Out, but we should pick one.
* grid filters and some cruft removal
* org selector. We should really find a way to leverage the AdminPageComponent here rather than crib code from it.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
15 files changed:
Open-ILS/examples/fm_IDL.xml
Open-ILS/src/eg2/src/app/share/boolean-select/boolean-select.component.css [new file with mode: 0644]
Open-ILS/src/eg2/src/app/share/boolean-select/boolean-select.component.html [new file with mode: 0644]
Open-ILS/src/eg2/src/app/share/boolean-select/boolean-select.component.ts [new file with mode: 0644]
Open-ILS/src/eg2/src/app/share/common-widgets.module.ts
Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/circ-matrix-matchpoint.component.html
Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/circ-matrix-matchpoint.component.ts
Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/circ-matrix-matchpoint.module.ts
Open-ILS/src/eg2/src/app/staff/admin/local/circ_matrix_matchpoint/linked-circ-limit-sets.component.html
Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/src/sql/Pg/upgrade/XXXX.data.circPolicy-grid-ws-settings.sql [new file with mode: 0644]
docs/RELEASE_NOTES_NEXT/miscellaneous.adoc