projects / working / Evergreen.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 22857ee) | patch
LP#1749795 Close circ on adjustment when rebilled user/jeffdavis/lp1749795_close_xact_adjust_fix-signoff
authorDan Wells <dbw2@calvin.edu>
Mon, 30 Apr 2018 15:05:11 +0000 (11:05 -0400)
committerJeff Davis <jdavis@sitka.bclibraries.ca>
Fri, 29 Jun 2018 22:19:59 +0000 (15:19 -0700)
commitd3601599dbac0c922e42475374a6a623f6e20e3b
tree77bac93917d2b4f46fc4eaff01832c5974958fc9tree
parent22857eef3cbc5c49c44cf99c82e93b6e224514d2commit | diff
LP#1749795 Close circ on adjustment when rebilled

When doing a re-bill, we were aborting too early when it rebilled to
exactly zero.  Move the 'zero' check to the top of the loop, and
thereby make sure we check if the xact can be closed if we do any
adjustment, up or down.

To test:
- Run new billing test from previous commit, see it fail
- Apply patch
- Run tests again; all should pass

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm diff | blob | history
Evergreen ILS