LP#1468422 Report inactive card on password OK
authorBill Erickson <berickxx@gmail.com>
Mon, 11 Jan 2016 16:02:23 +0000 (11:02 -0500)
committerBill Erickson <berickxx@gmail.com>
Wed, 17 Feb 2016 22:21:33 +0000 (17:21 -0500)
commitd8bd0ba05331b16a953c127234545c9e62cf5027
treec4e90b9d6077f000535c6da01a84f0de755c9aee
parent9ed3efdfcc8a9b6feff7572f0d80ce93395a18b4
LP#1468422 Report inactive card on password OK

Prevent leaking information from authentication by only reporting that a
card is inactive if the caller provided the correct credentials.  This
is consistent with how the code handles inactive patrons.

To avoid a lot of code duplication and to reduce the potential for
leaking memory (C code, amiright?), this commit includes a number of
changes to avoid exiting the API function early and saving the memory
cleanup routines until the end of the API call.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/c-apps/oils_auth.c