LP#1642344: XUL report cloning
authorGalen Charlton <gmc@equinoxinitiative.org>
Fri, 29 Jun 2018 18:45:27 +0000 (14:45 -0400)
committerChris Sharp <csharp@georgialibraries.org>
Tue, 14 Aug 2018 14:54:44 +0000 (10:54 -0400)
commitde1008d8247a604742f54eb1aef0b56650cb78d5
tree91b204845fd167bfe2b81086ca06bc891b67e4ca
parent288290e0957bd8b0bcd112ca754e98287a133639
LP#1642344: XUL report cloning

This patch allows report templates of version 4 and earlier
(which would have been created by the XUL staff client) to
be upgraded to template version 5 (used by the web staff
client) when the user clones a report. This closes a limitation
introduced in the reporter module for the web staff client.

Note that during the conversion, inner joins are used by
default when IDL classes have a 'has_a' relation rather than
defaulting to left outer joins, improving correctness of the
generated SQL query.

To test
-------
[0] Apply the patch.
[1] In a test database that has reporter templates created
    by (or for) the XUL staff client, create clones of
    those templates.
[2] Verify that the output of reports created using the new
    templates matches output of reports from the original
    templates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Open-ILS/web/js/ui/default/staff/reporter/template/app.js
Open-ILS/web/js/ui/default/staff/test/unit/egReporter.js [new file with mode: 0644]
Open-ILS/web/reports/oils_rpt_folder_window.js