Lp 1835620: Require some Storage submodules instead of use them
authorJason Stephenson <jason@sigio.com>
Sun, 7 Jul 2019 11:18:01 +0000 (07:18 -0400)
committerJason Boyer <jboyer@equinoxinitiative.org>
Wed, 23 Oct 2019 14:32:27 +0000 (10:32 -0400)
commite411c1cf41cdcd138a5163dc5361fe6d13d5e1aa
tree5d5ac561269553ad81f75973c56b5ed171327201
parente0d535c28fe023698dd7bc268677286c84737454
Lp 1835620: Require some Storage submodules instead of use them

Switch from "use" to "require" for submodules in OpenILS::Application
::Storage::CDBI and OpenILS::Application::Storage::Driver::Pg.
Circular dependencies and other issues cause the following errors at
compile time for those modules:

Compilation failed in require at
/usr/local/share/perl/5.28.1/OpenILS/Application/Storage/CDBI.pm line
9.

Compilation failed in require at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Driver/Pg.pm
line 15.

Require loads the submodules at run time and does not attempt to
import any methods.  This is the behavior we want, eliminates the
above errors, and everything still works.

Add comments above the required modules explaining why require is
needed and not use.

Enable and reorder all of the tests in Open-ILS/src/perlmods/t/
09-OpenILS-Application-Storage-Driver.t.  Repairing the above issue
also repairs these tests.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm
Open-ILS/src/perlmods/t/09-OpenILS-Application-Storage-Driver.t