LP 1786534: Don't merge a user with itself.
authorJason Stephenson <jason@sigio.com>
Fri, 10 Aug 2018 19:10:04 +0000 (15:10 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Thu, 13 Sep 2018 14:10:02 +0000 (10:10 -0400)
commitecae2ccba6ef760ea1ad90e1e7cac2fa60fe3dd7
treebd8412b3292b91d005086818edb73356efb345a8
parent868904789b1be09470fc1deca68cc4789248719a
LP 1786534: Don't merge a user with itself.

It's possible to merge a user with itself using the actor.usr_merge
database function.  This does not produce a useful result.  One ends
up with a user that is flagged deleted, has a null card field, and is
likely to have their addresses and other cards deleted from the
database.

A simple check at the top of the database function to bail if the
src_usr and dest_usr are the same prevents this from happening.  That
is the change that this commit makes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/sql/Pg/999.functions.global.sql
Open-ILS/src/sql/Pg/upgrade/XXXX.schema.actor_usr_merge-bail-on-same-user.sql [new file with mode: 0644]