Improvements to custom org tree UI user/kmlussier/custom-org-tree-UI-repairs-signoff
authorBill Erickson <berick@esilibrary.com>
Thu, 23 Aug 2012 21:29:42 +0000 (17:29 -0400)
committerKathy Lussier <klussier@masslnc.org>
Fri, 7 Sep 2012 20:25:48 +0000 (16:25 -0400)
commited4f4d82783f912308b89d3e5de878d73d2a281d
tree2527a963424fb285a640b4a7ef02b0c315342ae0
parent2843eb6c81f0d330f7eac7da43369538437531dc
Improvements to custom org tree UI

This replaced the PermaCrud.js create() calls with inline transaction
begin, creates, and commit.  We do this to solve a number of problems:

* Create all new nodes within the same transaction so that a failure
gracefully rolls back.

* PermaCrud.js does not currently disconnect opensrf client sessions
(though it has a disconnect() method), which can lead to pcrud drone
exhaustion when processing large batches of creates, etc.

* Re-using the same opensrf session leads to re-using the thread trace
(opensrf.js bug), which causes requests to intermittently fail as pcrud
backends slowly die off (see bug above), which causes their translater
cache entry to clear, which causes new sessions to fail when the hit the
translater with an already-cleared translator cache key.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Open-ILS/web/js/ui/default/conify/global/actor/org_unit_custom_tree.js