Lp 1861319: Repair expire setting logic
authorJason Stephenson <jason@sigio.com>
Mon, 25 Jan 2021 19:23:41 +0000 (14:23 -0500)
committerJason Stephenson <jason@sigio.com>
Mon, 1 Feb 2021 14:30:58 +0000 (09:30 -0500)
commitf79dd2556f7e976ca82fb514f49e8a3a4edb504e
tree0f79c5223cf09e90fc35e44982f231ad2e3aac25
parent2f5d5f2b56fa0f7a19342e5debce3aed3e6a11c4
Lp 1861319: Repair expire setting logic

Move the checks in Circulate.pm from mk_env to do_renew after the
circ_lib has been set for opac, auto, and desk renewals.

Only check for expired patrons in mk_env if we're not doing a renewal,
i.e. it's a regular checkout.

OPINION: That checks for patron validity in mk_env should be moved to
their own subroutine and called from do_checkout and do_renew.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm