LP#1198465 CircCommon fine generator repairs collab/berick/lp1198465-cstore-fine-gen-squash
authorBill Erickson <berickxx@gmail.com>
Fri, 20 Feb 2015 17:04:51 +0000 (12:04 -0500)
committerBill Erickson <berickxx@gmail.com>
Fri, 20 Feb 2015 21:20:43 +0000 (16:20 -0500)
commitd50fe3e9d76cfcc4a69b3c1026604fcda3e76d80
tree209a4ee781dc123b0dbd9d729d0120df4abd2c1f
parent170f947a36491f707c199e94d047dde29e2ffc46
LP#1198465 CircCommon fine generator repairs

* The latest fine generator uses ID-based transaction lookup.
  Avoid calling ->to_fieldmapper on IDs.

* Consistent with the previous fine generator code, handle each circ,
  reservation, etc. within its own transaction to avoid any long-running
  transactions.

* cstore expects order_by's to be delineated by object class

* CStoreEditor requires all params that are passed through to cstore to
  be contained within the first parameter to a search_*, etc. calls, so
  wrap the query and order_by clauses in an array.

  Without these changes, the fine generator would generate duplicate
  billings when voided billings were present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm