LP#1424815: Cleanup/simplify perl and template collab/kmlussier/lp1424815_long_fields_accordion_jquery-approach
authorRemington Steed <rjs7@calvin.edu>
Fri, 23 Feb 2018 21:57:07 +0000 (16:57 -0500)
committerKathy Lussier <klussier@masslnc.org>
Tue, 12 Jun 2018 19:49:18 +0000 (15:49 -0400)
commit40960d0ff0bc217c6b4d669dc8c5384892cec1d0
tree24d921b666590a77471e552c709683de20d4d466
parent9bab9b4f286134e03885a0e5a2b7f0890008cf0b
LP#1424815: Cleanup/simplify perl and template

This commit attempts to cleanup and simplify the "Read more" catalog
feature by making the following changes:

  - Simplify perl util function
    - Remove extra blank lines
    - Remove first IF branch, since rindex already covers this case
    - Remove "rest" from return value, since Kathy's changed stopped
      using it
    - Add logic to address the FIXME comment
    - Add a few code comments

  - Simplify template
    - Only split a string if feature is turned on in config settings
    - Allow, but don't require, "trunc_length" on every marc note field
    - Add a few code comments

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/contents.tt2
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
Open-ILS/src/templates/opac/parts/record/contents.tt2