LP1929593 UPDATE_COPY_BARCODE permission collab/phasefx/lp1929593-edit-barcode-perm
authorJason Etheridge <jason@EquinoxOLI.org>
Tue, 24 Jan 2023 13:29:33 +0000 (08:29 -0500)
committerJason Etheridge <jason@EquinoxOLI.org>
Wed, 8 Mar 2023 19:38:03 +0000 (14:38 -0500)
commitf680a5e5cffdd4fa1498a1da1c9537be0c11c36d
tree10389e6faf53a3ce6732dc7d53c9947266a66146
parent2b28077d7b72b3f142c41efb64247627e3621101
LP1929593 UPDATE_COPY_BARCODE permission

This adds the permission UPDATE_COPY_BARCODE and a new API call,

  open-ils.cat.update_copy_barcode

which explicitly tests for both UPDATE_COPY_BARCODE and UPDATE_COPY,
with either being sufficient for allowing a barcode change.  Existing
Replace Barcode UI's in both Angular and AngularJS have been modified
to use this API call instead of the pcrud service.  One side-effect of
this has been better surfacing of errors, as errors in pcrud were
uncaught and bypassing the normal error handling.  This addresses
LP1951469.

The upgrade script gives any permission groups that already have the
UPDATE_COPY permission the new UPDATE_COPY_BARCODE permission at the
same depth, though it's technically not needed.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Open-ILS/src/eg2/src/app/staff/share/holdings/replace-barcode-dialog.component.ts
Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm
Open-ILS/src/perlmods/live_t/lp1929593-update-copy-barcode-perm.t [new file with mode: 0644]
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/src/sql/Pg/upgrade/XXXX.data.edit_barcode_perm.sql [new file with mode: 0644]
Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
Open-ILS/web/js/ui/default/staff/cat/item/replace_barcode/app.js
Open-ILS/web/js/ui/default/staff/circ/services/item.js
docs/RELEASE_NOTES_NEXT/miscellaneous.adoc