Improvements to custom org tree UI user/berick/custom-org-tree-UI-repairs
authorBill Erickson <berick@esilibrary.com>
Thu, 23 Aug 2012 21:29:42 +0000 (17:29 -0400)
committerBill Erickson <berick@esilibrary.com>
Thu, 23 Aug 2012 21:29:42 +0000 (17:29 -0400)
commit2ed7877d836ba30ab0580f6ae072a16b7422f15f
treefb24040c69aa0c165f17e771de05ddc5734291e7
parent5e892c31a8b66ac0029d70446581ee4bae2dc018
Improvements to custom org tree UI

This replaced the PermaCrud.js create() calls with inline transaction
begin, creates, and commit.  We do this to solve a number of problems:

* Create all new nodes within the same transaction so that a failure
gracefully rolls back.

* PermaCrud.js does not currently disconnect opensrf client sessions
(though it has a disconnect() method), which can lead to pcrud drone
exhaustion when processing large batches of creates, etc.

* Re-using the same opensrf session leads to re-using the thread trace
(opensrf.js bug), which causes requests to intermittently fail as pcrud
backends slowly die off (see bug above), which causes their translater
cache entry to clear, which causes new sessions to fail when the hit the
translater with an already-cleared translator cache key.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Open-ILS/web/js/ui/default/conify/global/actor/org_unit_custom_tree.js