TPac: Avoid long-running, unintended empty searches user/berick/tpac-avoid-empty-query
authorBill Erickson <berick@esilibrary.com>
Mon, 23 Jan 2012 20:00:45 +0000 (15:00 -0500)
committerBill Erickson <berick@esilibrary.com>
Mon, 23 Jan 2012 20:10:05 +0000 (15:10 -0500)
commit7c4f56782c6a06e3970f13639b7da4240acfca6e
treeb6c5797426daf3c2479464a098065c987daac4f3
parent56fa348c351da2e4d1a9af9903c91a4b7ab8f33b
TPac: Avoid long-running, unintended empty searches

If a page that executes a search is accessed with no viable search
query, cut the search short to avoid meaningless, long-running searches.
This primarily affects direct links to record detail pages.  For
example:

http://example.org/eg/opac/record/123

The RD page attempts to load the currrently active search (for paging) and,
if there is no query, will search for strings like 'site(BR1) depth(2)',
which are unintended and quite slow, which delays page rendering.

---

While we're in there, let's silence the following Apache error log
warning by ensuring that int() gets a value.

Use of uninitialized value in int at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader/Search.pm line 192.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm